cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nvazquez <>
Subject [GitHub] cloudstack pull request #1735: CLOUDSTACK-9570: Bug in listSnapshots for sna...
Date Tue, 03 Jan 2017 14:24:44 GMT
Github user nvazquez commented on a diff in the pull request:
    --- Diff: api/src/org/apache/cloudstack/api/command/user/snapshot/
    @@ -115,8 +115,10 @@ public void execute() {
             List<SnapshotResponse> snapshotResponses = new ArrayList<SnapshotResponse>();
             for (Snapshot snapshot : result.first()) {
                 SnapshotResponse snapshotResponse = _responseGenerator.createSnapshotResponse(snapshot);
    -            snapshotResponse.setObjectName("snapshot");
    -            snapshotResponses.add(snapshotResponse);
    +            if (snapshotResponse != null) {
    +                snapshotResponse.setObjectName("snapshot");
    --- End diff --
    This check is added as we introduced a case in `createSnapshotResponse` null is returned,
and in that case we should skip the response

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message