cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anshul1886 <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1735: CLOUDSTACK-9570: Bug in listSnapshots for sna...
Date Tue, 03 Jan 2017 06:07:41 GMT
Github user anshul1886 commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1735#discussion_r94362243
  
    --- Diff: api/src/org/apache/cloudstack/api/command/user/snapshot/ListSnapshotsCmd.java
---
    @@ -115,8 +115,10 @@ public void execute() {
             List<SnapshotResponse> snapshotResponses = new ArrayList<SnapshotResponse>();
             for (Snapshot snapshot : result.first()) {
                 SnapshotResponse snapshotResponse = _responseGenerator.createSnapshotResponse(snapshot);
    -            snapshotResponse.setObjectName("snapshot");
    -            snapshotResponses.add(snapshotResponse);
    +            if (snapshotResponse != null) {
    +                snapshotResponse.setObjectName("snapshot");
    --- End diff --
    
    Is any issue observed here for which null check is added?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message