Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: Simon Weller <sweller@ena.com>
To: "dev@cloudstack.apache.org" <dev@cloudstack.apache.org>
Subject: Re: [VOTE] Apache Cloudstack 4.9.1.0 (RC1)
Thread-Topic: [VOTE] Apache Cloudstack 4.9.1.0 (RC1)
Thread-Index: AQHSUpM0bJveUF6EnUGIE6RG+8XL+qEE2n8AgAFnNYCAAP/vgIAAJU+AgAApR2c=
Date: Wed, 14 Dec 2016 15:05:45 +0000
Message-ID: <BY2PR02MB200727A05695E83E45AE8D66A99A0@BY2PR02MB2007.namprd02.prod.outlook.com>
References: <CANLSSBXeA02xc=FG=oGqjHN6E0E_ju+qY5wFOdoz0TDC2_eAqQ@mail.gmail.com>
 <584F1868.3000601@apache.org> <585045BB.6090000@apache.org>
 <1FDD3F45-EE71-4BFF-B06D-5A5B0F653F5A@shapeblue.com>,<B721F538-312B-4D9C-95C0-12F777EA6889@shapeblue.com>
In-Reply-To: <B721F538-312B-4D9C-95C0-12F777EA6889@shapeblue.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [132.245.243.37]
x-ms-office365-filtering-correlation-id: 2c8f857b-ae5f-42f7-34b3-08d42432ae5a
x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BY2PR02MB2007;
x-microsoft-exchange-diagnostics: 1;BY2PR02MB2007;7:jEyE3QZaGLPF/egX3bfG07hzpUA4XeaLTTPW8nLRKwsL0WJQzl/3TXCGigQhlklDmuEIq5JXHHy7bz1/9jpipw2/8O6d324trSdnt4oOTlFDrMAdSDasmE4S1bYDC4juv/5GuNZxgOcUNceULYbZ3heq9R6RS7GqLOQg2r08/DrLjDBYsBA0OQ3Vzpwk4CG6qqZ2AvcJhW0U97hxYydYDC6Hnex6W1NE2dcEewYbq21kD8inRhDwin36y2/s26Yw2ql2kUhebxs/7Aghp6L/qWR1sKnFfi7t9f/UPuJmuFB2XhQHypCoak//MLypvert03n6pa0l45eF0TE5hB3j2mreDi4x+tCJNPWdoLiLRSPenGlfoqRxjlS7scR/dlWu2ffLmxws76dvEJmuiinb12hVEDTfgEDbiA7czmgkeSeKk+Cicmr88+a6aLpQP7lW24cxWGC5sBb216LQ0wACvA==
x-microsoft-antispam-prvs: <BY2PR02MB2007B266213829D1F439910AA99A0@BY2PR02MB2007.namprd02.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(134217032509453)(166708455590820)(278021236550800)(17755550239193);
x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(20161123560025)(20161123555025)(20161123562025)(20161123558021)(20161123564025)(6072148);SRVR:BY2PR02MB2007;BCL:0;PCL:0;RULEID:;SRVR:BY2PR02MB2007;
x-forefront-prvs: 01565FED4C
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(7916002)(39850400002)(39840400002)(39450400003)(39410400002)(199003)(24454002)(377454003)(53754006)(377424004)(189002)(99286002)(93886004)(7696004)(92566002)(229853002)(189998001)(16601075003)(6506006)(733005)(2501003)(19618635001)(76576001)(66066001)(38730400001)(6606003)(606005)(15395725005)(6436002)(77096006)(2950100002)(6916009)(9686002)(2351001)(106116001)(2900100001)(107886002)(3280700002)(1730700003)(4001150100001)(97736004)(8936002)(105586002)(5660300001)(19627405001)(8676002)(86362001)(33656002)(68736007)(110136003)(106356001)(3900700001)(102836003)(81166006)(81156014)(74316002)(3660700001)(15974865002)(7906003)(122556002)(54356999)(3846002)(7736002)(6116002)(50986999)(76176999)(2906002)(101416001)(7099028)(15398625002);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR02MB2007;H:BY2PR02MB2007.namprd02.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en;
received-spf: None (protection.outlook.com: ena.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative;
	boundary="_000_BY2PR02MB200727A05695E83E45AE8D66A99A0BY2PR02MB2007namp_"
MIME-Version: 1.0
X-OriginatorOrg: ena.com
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2016 15:05:45.6933
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 6dc38cd4-4d4f-4826-9649-17854289d170
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR02MB2007
X-ENA-MailScanner-Information: Please contact support@ena.com for more information
X-ENA-MailScanner-ID: 8D96E1480C0C.A04BA
X-ENA-MailScanner: No viruses found
X-ENA-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-5.45,
	required 4, BAYES_00 -3.20, DKIM_SIGNED 0.10, DKIM_VALID -0.10,
	HTML_MESSAGE 1.20, KAM_LOTSOFHASH 0.25, OS_WINDOWS 0.20,
	OS_WINDOWS7 0.10, RCVD_IN_DNSWL_NONE -0.20, RCVD_IN_MSPIKE_H2 -1.20,
	RCVD_IN_SENDERSCORE_90_100 -2.20, SPF_HELO_PASS -0.20,
	SPF_PASS -0.20)
X-ENA-MailScanner-From: sweller@ena.com
X-ENA-MailScanner-Watermark: 1482332753.9749@wDHy3d3IBk4HR5BcSRuYfQ
archived-at: Wed, 14 Dec 2016 15:06:19 -0000

--_000_BY2PR02MB200727A05695E83E45AE8D66A99A0BY2PR02MB2007namp_
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: quoted-printable

Can you remove that column addition in the alter statement and see if the u=
pgrade continues?

Do you recall installing any customer version of ACS that may have included=
 DB schema patches?


________________________________
From: Boris Stoyanov <boris.stoyanov@shapeblue.com>
Sent: Wednesday, December 14, 2016 6:31 AM
To: dev@cloudstack.apache.org
Subject: Re: [VOTE] Apache Cloudstack 4.9.1.0 (RC1)

Hi,

We=92ve currently have a plan for upgrade testing covering the following sc=
enarios:
I=92ve tried upgrading from 4.5.2.2 to 4.9.1, but got the following excepti=
on:

2016-12-13 14:37:28,128 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -=
-
2016-12-13 14:37:28,128 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -=
- Schema upgrade from 4.5.1 to 4.6.0
2016-12-13 14:37:28,128 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -=
-
2016-12-13 14:37:28,128 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) A=
LTER TABLE `cloud`.`snapshots` ADD COLUMN `min_iops` bigint(20) unsigned CO=
MMENT 'Minimum IOPS'
2016-12-13 14:37:28,135 ERROR [c.c.u.d.ScriptRunner] (main:null) (logid:) E=
rror executing: ALTER TABLE `cloud`.`snapshots` ADD COLUMN `min_iops` bigin=
t(20) unsigned COMMENT 'Minimum IOPS'
2016-12-13 14:37:28,135 ERROR [c.c.u.d.ScriptRunner] (main:null) (logid:) c=
om.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: Duplicate column =
name 'min_iops'
2016-12-13 14:37:28,136 ERROR [c.c.u.DatabaseUpgradeChecker] (main:null) (l=
ogid:) Unable to execute upgrade script: /usr/share/cloudstack-management/s=
etup/db/schema-452to460.sql
com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: Duplicate column=
 name 'min_iops'
        at com.cloud.utils.db.ScriptRunner.runScript(ScriptRunner.java:185)
        at com.cloud.utils.db.ScriptRunner.runScript(ScriptRunner.java:87)

We=92re currently having a plan to cover upgrade testing to 4.9.1 from 4.3,=
 4.5.2.2, 4.6.0. I=92d love to continue with testing these upgrade scenario=
s once we fix the issue.

Currently also we=92re executing component tests against the following comb=
inations:

[KVM]
MS CentOS68 + KVM hosts CentOS68
MS CentOS72 + KVM hosts CentOS72

[VMware]
MS CentOS68 + VMware55u3
MS CentOS68 + VMware60u2
MS CentOS68 + VMware65

MS CentOS72 + VMware55u3
MS CentOS72 + VMware60u2
MS CentOS72 + VMware65

[XenServer]
MS CentOS68 + XenServer62sp1
MS CentOS68 + XenServer65sp1

MS CentOS72+ XenServer65sp1

*Once we get 4.9.1 we=92re looking fw to test XenServer 7 as well, as part =
of 4.9.2.0


Smoke tests has passed on KVM, VMware and XenServer hosts with CentOS6 and =
CentOS7 MS.

Thanks,


boris.stoyanov@shapeblue.com
www.shapeblue.com<http://www.shapeblue.com>
[http://shapeblue.com/wp-content/uploads/2014/03/sungardonline1.jpg]<http:/=
/www.shapeblue.com/>

ShapeBlue - The CloudStack Company<http://www.shapeblue.com/>
www.shapeblue.com
Offers seamless Container-as-a-Service without disruption to user experienc=
e or business process Sevilla, Spain -- 17 November 2016 -- ShapeBlue, the


53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue


> On Dec 14, 2016, at 12:18 PM, Murali Reddy <muralimmreddy@gmail.com> wrot=
e:
>
> +1
>
> Based on smoke test results [1] and below tests run manually on VMware de=
ployment
>
>  - VM life cycle operations
>  - network life cycle operations
>  - verified source NAT, static NAT, PF, LB, VPC internal LB, network ACL,=
 firewall
>  - upgrade from 4.9 and 4.5.2
>
>
> IMO issue raised by Milamber should be fixed on 4.10. If the functionalit=
y does not exist in 4.9, then no need to have schema change in 4.8 to 4.9 u=
pgrade path.
>
> Redundant VPC VR functionality appears to be broken from last few release=
s. In my testing noticed both the VR getting stuck in backup or in unknown =
state. RVR test failed consistently in smoke tests [1]. We should at least =
release note them as known issues. I will check existing bugs and open new =
one if necessary.
>
> [1] https://github.com/apache/cloudstack/pull/1753
[https://avatars1.githubusercontent.com/u/95203?v=3D3&s=3D400]<https://gith=
ub.com/apache/cloudstack/pull/1753>

[4.9] Latest health test run by rhtyd =B7 Pull Request #1753 =B7 apache/clo=
udstack<https://github.com/apache/cloudstack/pull/1753>
github.com
Dummy PR to trigger tests on latest 4.9 branch @blueorangutan package


>
>
>
>
> On 14/12/16, 12:32 AM, "Milamber" <milamber@apache.org> wrote:
>
>>
>> Hello,
>>
>> I'm not sure, but perhaps we have an 'indirect' blocker for 4.9.1.0 RC1.
>>
>> Currently the upgrade from 4.9.1.0 RC1 to 4.10.0.0 SNAPSHOT don't works
>> because the schema-481to490.sql in the 4.9.1.0 / 4.9 doesn't contains
>> the commit of CLOUDSTACK-9438 (2e77496601ab5420723ce8b955b3960faaba7d5c)=
.
>> (this commit is currently in master)
>>
>> When you try to make the upgrade you have this error: "Unknown column
>> 'image_store_details.display' in 'field list'"
>> see:  https://issues.apache.org/jira/browse/CLOUDSTACK-9671
>>
>> Currently there have 2 diff between the schema-481to490.sql in 4.9.1.0
>> RC1 (and 4.9 branch) and master branch.
>>
>> What is your opinion: blocker or not?
>>
>> Just copy the 2 sql request inside the schema-4910to41000.sql file (but
>> the commit 2e77496601ab5420723ce8b955b3960faaba7d5c contains other
>> modified files)?
>>
>> Milamber
>>
>>
>>
>> $ diff ./setup/db/db/schema-481to490.sql /tmp/MASTER-schema-481to490.sql
>> 547a548,552
>>>
>>> ALTER TABLE `cloud`.`image_store_details` CHANGE COLUMN `value`
>> `value` VARCHAR(255) NULL DEFAULT NULL COMMENT 'value of the detail',
>> ADD COLUMN `display` tinyint(1) NOT
>>> NULL DEFAULT '1' COMMENT 'True if the detail can be displayed to the
>> end user' AFTER `value`;
>>>
>>> ALTER TABLE `snapshots` ADD COLUMN `location_type` VARCHAR(32)
>> COMMENT 'Location of snapshot (ex. Primary)';
>>
>>
>>
>>
>>
>> On 12/12/2016 21:36, Milamber wrote:
>>> Hello,
>>>
>>> My vote +1 (binding)
>>>
>>> Tests are passed on a virtual topology of servers  (CS over CS)
>>> (1mgr+2nodes+1nfs) :
>>>
>>> 1/ Fresh install of 4.9.1.0 RC1 (adv net) on Ubuntu 14.04.5 + KVM +
>>> NFS : OK
>>> Some standard tests with success (create vm, migration, HA, create
>>> networks, create user, create ssh key, destroy vm, register template,
>>> create snapshot, restore snapshot, create template, ip association, ip
>>> release, static nat, firewall rule)
>>> Some tests with cloudstack ansible module with success too (create
>>> network, register templates, create vm, ip, firewall rule)
>>>
>>> 2/ Test upgrade from 4.8.1 to 4.9.1.0 RC1 : OK
>>>
>>> 3/ Test upgrade from 4.8.2 RC1 to 4.9.1.0 RC1 : don't works (expected)
>>>
>>> 4/ Tests of all localization Web UI for 4.9.1.0 RC1:
>>> Localization works well except Spanish (not a blocker to release): the
>>> Web UI display partially the localization strings due of one bad
>>> carriage return in the label
>>> message.installWizard.copy.whatIsCloudStack string (from Transifex).
>>> This is the same issue that the 4.8.2 RC1.
>>>
>>>
>>> Perhaps add in the Release notes this Spanish l10n issue.
>>>
>>> Thanks to the RM.
>>>
>>> Milamber
>>>
>>>
>>>
>>> On 10/12/2016 03:11, Rohit Yadav wrote:
>>>> Hi All,
>>>>
>>>> I've created a 4.9.1.0 release, with the following artifacts up for a
>>>> vote:
>>>>
>>>> Git Branch and Commit SH:
>>>> https://git-wip-us.apache.org/repos/asf?p=3Dcloudstack.git;a=3Dshortlo=
g;h=3Drefs/heads/4.9.1.0-RC20161210T0838
>>>>
>>>> Commit: af2679959b634d095b93b8265c6da294d360065d
>>>>
>>>> List of changes:
>>>> https://git-wip-us.apache.org/repos/asf?p=3Dcloudstack.git;a=3Dblob_pl=
ain;f=3DCHANGES;hb=3D4.9.1.0-RC20161210T0838
>>>>
>>>>
>>>> Source release (checksums and signatures are available at the same
>>>> location):
>>>> https://dist.apache.org/repos/dist/dev/cloudstack/4.9.1.0/
>>>>
>>>> PGP release keys (signed using 0EE3D884):
>>>> https://dist.apache.org/repos/dist/release/cloudstack/KEYS
dist.apache.org<https://dist.apache.org/repos/dist/release/cloudstack/KEYS>
dist.apache.org
This file contains the PGP keys of various developers. Users: pgp KEYS gpg =
--import KEYS Developers: pgp -kxa and append it to this file.


>>>>
>>>> Vote will be open for 120 hours, considering the process started
>>>> during the
>>>> weekends, and will end on 14 Dec 2016 end of the day.
>>>>
>>>> For sanity in tallying the vote, can PMC members please be sure to
>>>> indicate
>>>> "(binding)" with their vote?
>>>>
>>>> [ ] +1  approve
>>>> [ ] +0  no opinion
>>>> [ ] -1  disapprove (and reason why)
>>>>
>>>> Regards.
>>>>
>>>
>>>
>>
>


--_000_BY2PR02MB200727A05695E83E45AE8D66A99A0BY2PR02MB2007namp_--