Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: koushik-das <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1722-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1722-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request #1722: CLOUDSTACK-9558 Cleanup the snapshots on the ...
Content-Type: text/plain
Message-Id: <20161207092036.5B600E0159@git1-us-west.apache.org>
Date: Wed,  7 Dec 2016 09:20:36 +0000 (UTC)
archived-at: Wed, 07 Dec 2016 09:20:38 -0000

Github user koushik-das commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1722#discussion_r91252165
  
    --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java ---
    @@ -260,11 +260,15 @@ public boolean deleteSnapshot(Long snapshotId) {
                 boolean result = deleteSnapshotChain(snapshotOnImage);
                 obj.processEvent(Snapshot.Event.OperationSucceeded);
                 if (result) {
    -                //snapshot is deleted on backup storage, need to delete it on primary storage
    -                SnapshotDataStoreVO snapshotOnPrimary = snapshotStoreDao.findBySnapshot(snapshotId, DataStoreRole.Primary);
    -                if (snapshotOnPrimary != null) {
    -                    snapshotOnPrimary.setState(State.Destroyed);
    -                    snapshotStoreDao.update(snapshotOnPrimary.getId(), snapshotOnPrimary);
    +                SnapshotInfo snapshotOnPrimary = snapshotDataFactory.getSnapshot(snapshotId, DataStoreRole.Primary);
    +                if(snapshotSvr.deleteSnapshot(snapshotOnPrimary)) {
    --- End diff --
    
    What happens if deleteSnapshot fails? Will it be retried again? If not should the DB be always cleaned up whether snapshot removal from primary is successful or not?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---