Return-Path: <dev-return-102599-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id CFEB0200BD4
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Fri,  2 Dec 2016 06:36:12 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id CBBAE160B25; Fri,  2 Dec 2016 05:36:12 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 1ED16160B0B
	for <archive-asf-public@cust-asf.ponee.io>; Fri,  2 Dec 2016 06:36:11 +0100 (CET)
Received: (qmail 2821 invoked by uid 500); 2 Dec 2016 05:36:10 -0000
Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cloudstack.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cloudstack.apache.org>
List-Post: <mailto:dev@cloudstack.apache.org>
List-Id: <dev.cloudstack.apache.org>
Reply-To: dev@cloudstack.apache.org
Delivered-To: mailing list dev@cloudstack.apache.org
Received: (qmail 2796 invoked by uid 99); 2 Dec 2016 05:36:10 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Dec 2016 05:36:10 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 4A752ED312; Fri,  2 Dec 2016 05:36:10 +0000 (UTC)
From: jburwell <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-873-cloudstack@git.apache.org>
In-Reply-To: <git-pr-873-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request #873: CLOUDSTACK-8896: allocated percentage of stora...
Content-Type: text/plain
Message-Id: <20161202053610.4A752ED312@git1-us-west.apache.org>
Date: Fri,  2 Dec 2016 05:36:10 +0000 (UTC)
archived-at: Fri, 02 Dec 2016 05:36:13 -0000

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/873#discussion_r90589284
  
    --- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
    @@ -1719,6 +1719,7 @@ public boolean storagePoolHasEnoughSpace(List<Volume> volumes, StoragePool pool,
             }
     
             // allocated space includes templates
    +        s_logger.debug("Destination pool id: " + pool.getId());
    --- End diff --
    
    Please wrap this `DEBUG` log in an `if (s_logger.isDebugEnabled)` check to prevent unnecessary/expensive string concatenation when `DEBUG` logging is not enabled.  Also, please add context to message to explain what operation is being performed for the destination pool.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---