cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudhansu7 <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1805: CLOUDSTACK-9637: Template create from snapsho...
Date Thu, 01 Dec 2016 18:47:31 GMT
GitHub user sudhansu7 opened a pull request:

    https://github.com/apache/cloudstack/pull/1805

    CLOUDSTACK-9637: Template create from snapshot does not populate vm_t…

    
    **ISSUE**
    ============
    Template create from snapshot does not populate vm_template_details
    
    **REPRO STEPS**
    ==================
    1. Register a template A and specify property:
    Root disk controller: scsi
    NIC adapter type: E1000
    Keyboard type: us
    
    2. Create a vm instance from template A
    
    3. Take volume snapshot for vm instance
    
    4. Delete VM instance
    
    5. Switch to "Storage->Snapshots", convert snapshot to a template B
    
    6. Observe template B does not inherit property from template A, the table vm_template_details
is empty
    
    
    **SOLUTION**: Retrieve and add source template details to VMTemplateVO.
    
    `Before Fix:
    
    mysql> select id,name,source_template_id from vm_template where id=202; 
    +-----+--------+--------------------+
    | id  | name   | source_template_id |
    +-----+--------+--------------------+
    | 202 | Debian |               NULL |
    +-----+--------+--------------------+
    1 row in set (0.00 sec)
    
    mysql> select * from vm_template_details where template_id=202; 
    +----+-------------+--------------------+-------+---------+
    | id | template_id | name               | value | display |
    +----+-------------+--------------------+-------+---------+
    |  1 |         202 | keyboard           | us    |       1 |
    |  2 |         202 | nicAdapter         | E1000 |       1 |
    |  3 |         202 | rootDiskController | scsi  |       1 |
    +----+-------------+--------------------+-------+---------+
    3 rows in set (0.00 sec)
    
    mysql> select id,name,source_template_id from vm_template where source_template_id=202;
    +-----+----------------+--------------------+
    | id  | name           | source_template_id |
    +-----+----------------+--------------------+
    | 203 | derived-debian |                202 |
    +-----+----------------+--------------------+
    1 row in set (0.00 sec)
    
    mysql> select * from vm_template_details where template_id=203;
    Empty set (0.00 sec)
    
    
    After Fix:
    
    mysql> select id,name,source_template_id from vm_template where source_template_id=202;
    +-----+--------------------------+--------------------+
    | id  | name                     | source_template_id |
    +-----+--------------------------+--------------------+
    | 203 | derived-debian           |                202 |
    | 204 | debian-derived-after-fix |                202 |
    +-----+--------------------------+--------------------+
    2 rows in set (0.00 sec)
    
    mysql> select * from vm_template_details where template_id=204;
    +----+-------------+--------------------+-------+---------+
    | id | template_id | name               | value | display |
    +----+-------------+--------------------+-------+---------+
    |  4 |         204 | keyboard           | us    |       1 |
    |  5 |         204 | nicAdapter         | E1000 |       1 |
    |  6 |         204 | rootDiskController | scsi  |       1 |
    +----+-------------+--------------------+-------+---------+
    3 rows in set (0.00 sec)`
    
    **Marvin Test :** test_template_from_snapshot_with_template_details.py
    
    **Result:**
    test_01_create_template_snampshot (integration.component.test_template_from_snapshot_with_template_details.TestCreateTemplate)
... === TestName: test_01_create_template_snampshot | Status : SUCCESS ===
    ok
    
    ----------------------------------------------------------------------
    Ran 1 test in 864.523s
    
    OK

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sudhansu7/cloudstack CLOUDSTACK-9637

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1805.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1805
    
----
commit 9da5a6afe30838ddc82847d15a9bebf4cb4bcb7f
Author: Sudhansu <sudhansu.sahu@accelerite.com>
Date:   2016-12-01T18:38:12Z

    CLOUDSTACK-9637: Template create from snapshot does not populate vm_template_details
    
    Summary: Retrieve and add source template details to VMTemplateVO.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message