cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nitin-maharana <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1804: CLOUDSTACK-9639: Unable to create shared netw...
Date Thu, 01 Dec 2016 07:26:14 GMT
GitHub user nitin-maharana opened a pull request:

    https://github.com/apache/cloudstack/pull/1804

    CLOUDSTACK-9639: Unable to create shared network with vLan isolation

    Description:
    =========
    Create shared network fails with Error.
    While creating a shared network it fails to create with Error "The new IP range you have
specified has overlapped with the guest network in the zone: XYZ. Please specify a different
gateway/netmask"
    
    Steps to Reproduce:
    ===============
    1. Create an isolated network with a subnet eg: 10.1.1.0.24
    2. Create a shared network with the same subnet but different VLAN, we should observe
this issue.
    
    Expected Behaviour:
    ===============
    It shouldn't restrict the creation of the guest network with the same subnet as long as
they are segmented by VLAN.
    
    ACTUAL BEHAVIOR:
    ===============
    It doesn't allow the creation of shared guest networks if there is any isolated guest
network using the same subnet although it allows using the same subnet in multiple shared
networks.
    
    Cause:
    =====
    The issue is happening because, when Shared network is getting created we are checking
if there is any guest network already implemented with the same CIDR and throwing the error
without checking if they are having same VLAN also. Creating the same CIDR shared network
with different VLAN should be allowed.
    
    Fix:
    ===
    When creating a shared network, if there is any existing guest network with the same CIDR,
we check if they are having the same VLAN, if they are in same VLAN, then we don't allow creating
it. If they are in the same CIDR with different VLAN then we allowing to create the network.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-9639

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1804.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1804
    
----
commit fc4434846433f8df64998614deb6c1b4b40992da
Author: Nitin Kumar Maharana <nitinkumar.maharana@accelerite.com>
Date:   2016-12-01T07:13:49Z

    CLOUDSTACK-9639: Unable to create shared network with vLan isolation

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message