cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From koushik-das <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1861: CLOUDSTACK-9698 Make hardcorded wait timeout ...
Date Fri, 30 Dec 2016 07:12:35 GMT
Github user koushik-das commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1861#discussion_r94206888
  
    --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
    @@ -839,7 +840,12 @@ private int findRouterEthDeviceIndex(String domrName, String routerIp,
String ma
             // when we dynamically plug in a new NIC into virtual router, it may take time
to show up in guest OS
             // we use a waiting loop here as a workaround to synchronize activities in systems
             long startTick = System.currentTimeMillis();
    -        while (System.currentTimeMillis() - startTick < 15000) {
    +        long waitTimeoutMillis = 15000;
    +        Long waitTimeoutMillisLong = VmwareManagerImpl.s_vmwareNicHotplugWaitTimeout.value();
    +        if (waitTimeoutMillisLong != null) {
    +            waitTimeoutMillis = waitTimeoutMillisLong;
    +        }
    +        while (System.currentTimeMillis() - startTick < waitTimeoutMillis) {
    --- End diff --
    
    The config value can be directly read using s_vmwareNicHotplugWaitTimeout.value(), no
need for the checks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message