cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rajesh-battala <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1859: CLOUDSTACK - 8672 : NCC Integration with Clou...
Date Fri, 23 Dec 2016 10:15:03 GMT
Github user rajesh-battala commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1859#discussion_r93746542
  
    --- Diff: engine/schema/src/com/cloud/dc/dao/DataCenterIpAddressDaoImpl.java ---
    @@ -177,6 +177,22 @@ public void releaseIpAddress(long nicId, String reservationId) {
         }
     
         @Override
    +    public void releasePodIpAddress(long id) {
    +        if (s_logger.isDebugEnabled()) {
    +            s_logger.debug("Releasing ip address for ID=" + id);
    +        }
    +//        SearchCriteria<DataCenterIpAddressVO> sc = AllFieldsSearch.create();
    +//        sc.setParameters("id", id);
    +
    +        DataCenterIpAddressVO vo = this.findById(id);
    +        vo.setTakenAt(null);
    +        vo.setInstanceId(null);
    +        vo.setReservationId(null);
    +        persist(vo);
    +        //update(vo, sc);
    --- End diff --
    
    Remove unused code


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message