cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From abhinandanprateek <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...
Date Tue, 06 Dec 2016 03:37:02 GMT
Github user abhinandanprateek commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1600#discussion_r91006590
  
    --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625StorageProcessor.java
---
    @@ -538,7 +562,7 @@ public Answer backupSnapshot(final CopyCommand cmd) {
                         final String[] tmp = result.split("#");
                         snapshotBackupUuid = tmp[0];
                         physicalSize = Long.parseLong(tmp[1]);
    -                    finalPath = folder + File.separator + snapshotBackupUuid;
    +                    finalPath = folder + File.separator + snapshotBackupUuid + ".vhd";
    --- End diff --
    
    @syed This is the way it should have been, but now that in a upgraded setup there will
be mixed names with ".vhd" and without, do you think this will not cause issues ? If it does
we need to come up with a plan to deal with them like a upgrade step ? I think the cleanup
threads may not be able to handle the old naming convention for one.  @rhtyd 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message