cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...
Date Thu, 01 Dec 2016 14:49:53 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1579#discussion_r90451924
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
    @@ -387,41 +400,39 @@ public boolean canEnableIndividualServices() {
     
         @Override
         public boolean destroy(Network network, ReservationContext context) throws ConcurrentOperationException,
ResourceUnavailableException {
    -        if (!canHandle(network, Service.Connectivity)) {
    -            return false;
    -        }
    -
    -        return true;
    +        return canHandle(network, Service.Connectivity);
         }
     
         @Override
         public boolean verifyServicesCombination(Set<Service> services) {
    --- End diff --
    
    The method assumes that `services` is not `null`.  Therefore, please consider adding a
`Preconditions.checkArgument` check to verify that `services` is not `null`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message