cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...
Date Thu, 01 Dec 2016 14:49:53 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1579#discussion_r90452488
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
---
    @@ -255,7 +284,30 @@ public void reserve(NicProfile nic, Network network, VirtualMachineProfile
vm, D
                 }
     
                 HostVO nuageVspHost = _nuageVspManager.getNuageVspHost(network.getPhysicalNetworkId());
    -            VspNetwork vspNetwork = _nuageVspEntityBuilder.buildVspNetwork(network, false);
    +            VspNetwork vspNetwork = _nuageVspEntityBuilder.buildVspNetwork(vm.getVirtualMachine().getDomainId(),
network);
    +
    +            if (vspNetwork.isShared()) {
    +                vspNetwork = _nuageVspEntityBuilder.updateVspNetworkByPublicIp(vspNetwork,
network, nic.getIPv4Address());
    +
    +                if (VirtualMachine.Type.DomainRouter.equals(vm.getType()) &&
!nic.getIPv4Address().equals(vspNetwork.getVirtualRouterIp())) {
    +                    s_logger.debug("VR got spawned with a different IP, releasing the
previously allocated public IP " + nic.getIPv4Address());
    --- End diff --
    
    Please wrap this `DEBUG` log statement in an `if (s_logger.isDebugEnabled())` block to
avoid unnecessary string concatenation when `DEBUG` logging is not enabled.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message