cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <>
Subject [GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...
Date Thu, 01 Dec 2016 14:49:53 GMT
Github user jburwell commented on a diff in the pull request:
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/
    @@ -0,0 +1,63 @@
    +// Licensed to the Apache Software Foundation (ASF) under one
    +// or more contributor license agreements.  See the NOTICE file
    +// distributed with this work for additional information
    +// regarding copyright ownership.  The ASF licenses this file
    +// to you under the Apache License, Version 2.0 (the
    +// "License"); you may not use this file except in compliance
    +// with the License.  You may obtain a copy of the License at
    +// Unless required by applicable law or agreed to in writing,
    +// software distributed under the License is distributed on an
    +// KIND, either express or implied.  See the License for the
    +// specific language governing permissions and limitations
    +// under the License.
    +import net.nuage.vsp.acs.client.api.model.VspDomainCleanUp;
    +public class CleanUpDomainCommand extends Command {
    +    private final VspDomainCleanUp _domainCleanUp;
    +    public CleanUpDomainCommand(VspDomainCleanUp domainCleanUp) {
    --- End diff --
    Is it acceptable for `domainCleanup` to be `null`?  If not, please consider adding a `Preconditions.checkArgument`
check to verify that the `domainCleanup` is not `null`.  You may also be to remove `null`
checks from the `equals` and `hashCode` methods if this precondition is added.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message