cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...
Date Thu, 01 Dec 2016 14:49:53 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1579#discussion_r90455598
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResourceConfiguration.java
---
    @@ -0,0 +1,310 @@
    +//
    +// Licensed to the Apache Software Foundation (ASF) under one
    +// or more contributor license agreements.  See the NOTICE file
    +// distributed with this work for additional information
    +// regarding copyright ownership.  The ASF licenses this file
    +// to you under the Apache License, Version 2.0 (the
    +// "License"); you may not use this file except in compliance
    +// with the License.  You may obtain a copy of the License at
    +//
    +//   http://www.apache.org/licenses/LICENSE-2.0
    +//
    +// Unless required by applicable law or agreed to in writing,
    +// software distributed under the License is distributed on an
    +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +// KIND, either express or implied.  See the License for the
    +// specific language governing permissions and limitations
    +// under the License.
    +//
    +
    +package com.cloud.network.resource;
    +
    +import java.util.HashMap;
    +import java.util.Map;
    +
    +import javax.naming.ConfigurationException;
    +
    +import net.nuage.vsp.acs.client.api.model.NuageVspUser;
    +import net.nuage.vsp.acs.client.api.model.VspHost;
    +import net.nuage.vsp.acs.client.common.NuageVspApiVersion;
    +
    +import org.apache.commons.lang.builder.ToStringBuilder;
    +
    +import com.cloud.util.NuageVspUtil;
    +
    +public class NuageVspResourceConfiguration {
    +    private static final String NAME = "name";
    +    private static final String GUID = "guid";
    +    private static final String ZONE_ID = "zoneid";
    +    private static final String HOST_NAME = "hostname";
    +    private static final String CMS_USER = "cmsuser";
    +    private static final String CMS_USER_PASSWORD = "cmsuserpass";
    +    private static final String PORT = "port";
    +    private static final String API_VERSION = "apiversion";
    +    private static final String API_RELATIVE_PATH = "apirelativepath";
    +    private static final String RETRY_COUNT = "retrycount";
    +    private static final String RETRY_INTERVAL = "retryinterval";
    +    private static final String NUAGE_VSP_CMS_ID = "nuagevspcmsid";
    +
    +    private static final String CMS_USER_ENTEPRISE_NAME = "CSP";
    +
    +    private String _name;
    +    private String _guid;
    +    private String _zoneId;
    +    private String _hostName;
    +    private String _cmsUser;
    +    private String _cmsUserPassword;
    +    private String _port;
    +    private String _apiVersion;
    +    private String _apiRelativePath;
    +    private String _retryCount;
    +    private String _retryInterval;
    +    private String _nuageVspCmsId;
    +
    +    public String name() {
    +        return _name;
    +    }
    +
    +    public String guid() {
    +        return this._guid;
    +    }
    +
    +    public NuageVspResourceConfiguration guid(String guid) {
    +        this._guid = guid;
    +        return this;
    +    }
    +
    +    public String zoneId() {
    +        return this._zoneId;
    +    }
    +
    +    public NuageVspResourceConfiguration zoneId(String zoneId) {
    +        this._zoneId = zoneId;
    +        return this;
    +    }
    +
    +    public String hostName() {
    +        return this._hostName;
    +    }
    +
    +    public NuageVspResourceConfiguration hostName(String hostName) {
    +        this._hostName = hostName;
    +        this._name = "Nuage VSD - " + _hostName;
    +        return this;
    +    }
    +
    +    public String cmsUser() {
    +        return this._cmsUser;
    +    }
    +
    +    public NuageVspResourceConfiguration cmsUser(String cmsUser) {
    +        this._cmsUser = cmsUser;
    +        return this;
    +    }
    +
    +    public String cmsUserPassword() {
    +        return this._cmsUserPassword;
    +    }
    +
    +    public NuageVspResourceConfiguration cmsUserPassword(String cmsUserPassword) {
    +        this._cmsUserPassword = cmsUserPassword;
    +        return this;
    +    }
    +
    +    public String port() {
    +        return this._port;
    +    }
    +
    +    public NuageVspResourceConfiguration port(String port) {
    +        this._port = port;
    +        return this;
    +    }
    +
    +    public String apiVersion() {
    +        return this._apiVersion;
    +    }
    +
    +    public NuageVspResourceConfiguration apiVersion(String apiVersion) {
    +        this._apiVersion = apiVersion;
    +        return this;
    +    }
    +
    +    public String apiRelativePath() {
    +        return this._apiRelativePath;
    +    }
    +
    +    public NuageVspResourceConfiguration apiRelativePath(String apiRelativePath) {
    +        this._apiRelativePath = apiRelativePath;
    +        return this;
    +    }
    +
    +    public String retryCount() {
    +        return this._retryCount;
    +    }
    +
    +    public NuageVspResourceConfiguration retryCount(String retryCount) {
    +        this._retryCount = retryCount;
    +        return this;
    +    }
    +
    +    public String retryInterval() {
    +        return this._retryInterval;
    +    }
    +
    +    public NuageVspResourceConfiguration retryInterval(String retryInterval) {
    +        this._retryInterval = retryInterval;
    +        return this;
    +    }
    +
    +    public String nuageVspCmsId() {
    +        return this._nuageVspCmsId;
    +    }
    +
    +    public NuageVspResourceConfiguration nuageVspCmsId(String nuageVspCmsId) {
    +        this._nuageVspCmsId = nuageVspCmsId;
    +        return this;
    +    }
    +
    +    public String getRootPath(){
    --- End diff --
    
    Why represent a URI as a `String` instead of a `URI`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message