cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From abhinandanprateek <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...
Date Thu, 01 Dec 2016 12:37:05 GMT
Github user abhinandanprateek commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1600#discussion_r90438253
  
    --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625StorageProcessor.java
---
    @@ -538,7 +562,7 @@ public Answer backupSnapshot(final CopyCommand cmd) {
                         final String[] tmp = result.split("#");
                         snapshotBackupUuid = tmp[0];
                         physicalSize = Long.parseLong(tmp[1]);
    -                    finalPath = folder + File.separator + snapshotBackupUuid;
    +                    finalPath = folder + File.separator + snapshotBackupUuid + ".vhd";
    --- End diff --
    
    This change will result in a ".vhd" extension being written to snapshot_store_ref as this
is being returned in the CopyCmdAnswer. Although I prefer this, the implication of this change
is that there will be inconsistency in snapshot names in a setup upgraded to this version.
I am wondering and please confirm that this is not going to cause the UI to not show the older
snapshots, only thing will be that the older snapshots' install_path will be without extension.
For consistency can be modify the upgrade script to append ".vhd" to all the old Xen based
snapshots ?
    
    cc @rhtyd @jburwell 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message