cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rhtyd <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...
Date Thu, 01 Dec 2016 08:14:01 GMT
Github user rhtyd commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1799#discussion_r90399606
  
    --- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java ---
    @@ -111,37 +116,37 @@ public CertServiceImpl() {
         @DB
         @Override
         @ActionEvent(eventType = EventTypes.EVENT_LB_CERT_UPLOAD, eventDescription = "Uploading
a certificate to cloudstack", async = false)
    -    public SslCertResponse uploadSslCert(UploadSslCertCmd certCmd) {
    +    public SslCertResponse uploadSslCert(final UploadSslCertCmd certCmd) {
             try {
    -            String cert = certCmd.getCert();
    -            String key = certCmd.getKey();
    -            String password = certCmd.getPassword();
    -            String chain = certCmd.getChain();
    +            final String cert = certCmd.getCert();
    +            final String key = certCmd.getKey();
    +            final String password = certCmd.getPassword();
    +            final String chain = certCmd.getChain();
     
                 validate(cert, key, password, chain);
                 s_logger.debug("Certificate Validation succeeded");
     
    -            String fingerPrint = generateFingerPrint(parseCertificate(cert));
    +            final String fingerPrint = generateFingerPrint(parseCertificate(cert));
     
    -            CallContext ctx = CallContext.current();
    -            Account caller = ctx.getCallingAccount();
    +            final CallContext ctx = CallContext.current();
    +            final Account caller = ctx.getCallingAccount();
     
                 Account owner = null;
    -            if ((certCmd.getAccountName() != null && certCmd.getDomainId() !=
null) || certCmd.getProjectId() != null) {
    +            if (certCmd.getAccountName() != null && certCmd.getDomainId() !=
null || certCmd.getProjectId() != null) {
    --- End diff --
    
    Fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message