cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1798: CLOUDSTACK-9631: API: affinitygroupids or aff...
Date Thu, 01 Dec 2016 02:39:52 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1798#discussion_r90372709
  
    --- Diff: api/src/org/apache/cloudstack/api/command/user/affinitygroup/UpdateVMAffinityGroupCmd.java
---
    @@ -96,6 +96,10 @@ public Long getId() {
                 throw new InvalidParameterValueException("affinitygroupids parameter is mutually
exclusive with affinitygroupnames parameter");
             }
     
    +        if (affinityGroupNameList == null && affinityGroupIdList == null) {
    +            throw new InvalidParameterValueException("affinitygroupids parameter or affinitygroupnames
parameter must be given");
    +        }
    +
    --- End diff --
    
    Lines 95-102 should be at the beginning of the `execute` method rather than in an accessor.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message