Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: nvazquez <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1767-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1767-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack issue #1767: CLOUDSTACK-9457: Allow retrieval and modification of...
Content-Type: text/plain
Message-Id: <20161121150654.0918AE0999@git1-us-west.apache.org>
Date: Mon, 21 Nov 2016 15:06:54 +0000 (UTC)
archived-at: Mon, 21 Nov 2016 15:06:56 -0000

Github user nvazquez commented on the issue:

    https://github.com/apache/cloudstack/pull/1767
  
    Hi @koushik-das @ustcweizhou,
    For this new methods as they require the entity id (VM or template) I added a basic validation to check if the entity is found on DB, but I realize that I should also validate that entity is not destroyed. This data is to be stored in *details tables.
    About existing API methods, I have checked `updateTemplate` and `updateVirtualMachines` methods before adding this new methods, and they provide a way to add/update details (although updateTemplate overrides existing details). Also, details can be listed on `listTemplates` and `listVirtualMachines` but thought the best approach was introducing this new methods to reduce overhead and treat entity details separately instead of updating/listing the entity every time. What do you think of this approach? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---