Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: jburwell <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1545-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1545-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request #1545: CLOUDSTACK-8715: Add channel to Instances for...
Content-Type: text/plain
Message-Id: <20161117030254.D9D72F1793@git1-us-west.apache.org>
Date: Thu, 17 Nov 2016 03:02:54 +0000 (UTC)
archived-at: Thu, 17 Nov 2016 03:02:58 -0000

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1545#discussion_r88377937
  
    --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java ---
    @@ -175,6 +180,26 @@ public boolean parseDomainXML(String domXML) {
                     interfaces.add(def);
                 }
     
    +            NodeList ports = devices.getElementsByTagName("channel");
    +            for (int i = 0; i < ports.getLength(); i++) {
    +                Element channel = (Element)ports.item(i);
    +
    +                String type = channel.getAttribute("type");
    +                String path = getAttrValue("source", "path", channel);
    +                String name = getAttrValue("target", "name", channel);
    +                String state = getAttrValue("target", "state", channel);
    +
    +                ChannelDef def = null;
    +                if (!StringUtils.isNotBlank(state)) {
    --- End diff --
    
    Minor nit: Performing a logical not operation on the result `StringUtils.isNotBlank` seems a bit awkward.  Please consider refactoring to `if (StringUtlis.isBlank(state))`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---