cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ppenchev-storpool <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1780: Fix the KVM hypervisor's handling of not-real...
Date Thu, 24 Nov 2016 13:25:30 GMT
GitHub user ppenchev-storpool opened a pull request:

    https://github.com/apache/cloudstack/pull/1780

    Fix the KVM hypervisor's handling of not-really-SCSI devices.

    Hi,
    
    Thanks for developing and maintaining CloudStack!
    
    What do you think about the attached trivial patch that lets the KVM storage pool use
more than one type of storage adaptor?  If a disk is handled by another adaptor and a request
to disconnect it comes in, the KVM storage pool might hand it off to the iSCSI storage adaptor
first.  With the current iSCSI adaptor code, it will recognize that the disk is not one of
its own and return "true", signalling to the storage pool that the disk has been successfully
disconnected.  The patch makes it return "false" so that the storage pool will pass the request
to the *next* storage adaptor in the pool which might very well actually handle it.
    
    Thanks in advance for your time and attention, and keep up the great work!
    
    Best regards,
    Peter


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/storpool/cloudstack pp-scsi-pass

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1780.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1780
    
----
commit 847897a64662654cd1d59aae8531bdd157230d50
Author: Peter Pentchev <pp@storpool.com>
Date:   2016-06-14T14:36:21Z

    Fix the KVM hypervisor's handling of not-really-SCSI devices.
    
    Submitted by:		Gencho Zhilkov

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message