cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...
Date Wed, 30 Nov 2016 22:37:04 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1799#discussion_r90315713
  
    --- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java ---
    @@ -180,16 +185,16 @@ public void deleteSslCert(DeleteSslCertCmd deleteSslCertCmd) {
         }
     
         @Override
    -    public List<SslCertResponse> listSslCerts(ListSslCertsCmd listSslCertCmd) {
    -        CallContext ctx = CallContext.current();
    -        Account caller = ctx.getCallingAccount();
    +    public List<SslCertResponse> listSslCerts(final ListSslCertsCmd listSslCertCmd)
{
    --- End diff --
    
    Please consider adding a `Preconditions.checkArgument` check to verify that `listSslCertCmd`
is not `null`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message