cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...
Date Wed, 30 Nov 2016 22:37:02 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1799#discussion_r90314765
  
    --- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java ---
    @@ -176,18 +176,18 @@ public void runUploadSslCertSelfSignedWithPassword() throws Exception
{
             when(certService._accountDao.findByIdIncludingRemoved(anyLong())).thenReturn((AccountVO)account);
     
             //creating the command
    -        UploadSslCertCmd uploadCmd = new UploadSslCertCmdExtn();
    -        Class<?> _class = uploadCmd.getClass().getSuperclass();
    +        final UploadSslCertCmd uploadCmd = new UploadSslCertCmdExtn();
    +        final Class<?> klazz = uploadCmd.getClass().getSuperclass();
     
    -        Field certField = _class.getDeclaredField("cert");
    +        final Field certField = klazz.getDeclaredField("cert");
             certField.setAccessible(true);
             certField.set(uploadCmd, cert);
     
    -        Field keyField = _class.getDeclaredField("key");
    +        final Field keyField = klazz.getDeclaredField("key");
             keyField.setAccessible(true);
             keyField.set(uploadCmd, key);
     
    -        Field passField = _class.getDeclaredField("password");
    +        final Field passField = klazz.getDeclaredField("password");
             passField.setAccessible(true);
             passField.set(uploadCmd, password);
     
    --- End diff --
    
    This method has not assertions to verify the correctness of `certService.uploadSslCert`.
 Please consider adding such assertions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message