cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rhtyd <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...
Date Wed, 30 Nov 2016 12:18:00 GMT
Github user rhtyd commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1579#discussion_r90221096
  
    --- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java ---
    @@ -2968,8 +2939,45 @@ public Vlan doInTransaction(final TransactionStatus status) {
                 throw new InvalidParameterValueException("The gateway ip should not be the
part of the ip range being added.");
             }
     
    -        final Pair<Boolean, Pair<String, String>> result = new Pair<Boolean,
Pair<String, String>>(sameSubnet, vlanDetails);
    -        return result;
    +        return new Pair<Boolean, Pair<String, String>>(sameSubnet, vlanDetails);
    +    }
    +
    +    private boolean hasSameSubnet(boolean ipv4, String vlanGateway, String vlanNetmask,
String newVlanGateway, String newVlanNetmask, String newStartIp, String newEndIp,
    --- End diff --
    
    Do we have a unit test for this method?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message