cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudhansu7 <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1797: CLOUDSTACK-9630: Cannot use listNics API as a...
Date Tue, 29 Nov 2016 13:36:43 GMT
Github user sudhansu7 commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1797#discussion_r90009164
  
    --- Diff: server/src/com/cloud/api/ApiResponseHelper.java ---
    @@ -3461,10 +3470,21 @@ public NicResponse createNicResponse(Nic result) {
             response.setNetmask(result.getIPv4Netmask());
             response.setMacAddress(result.getMacAddress());
     
    +        if (result.getBroadcastUri() != null) {
    +            response.setBroadcastUri(result.getBroadcastUri().toString());
    --- End diff --
    
    @ustcweizhou As per api doc these info should be part of response. Even listVirtualMachines
with details=nics 
    `command=listVirtualMachines&details=nics&id=6eea5ceb-e943-4ef3-9f40-4671364d03ab&response=json`
provides these details.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message