cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From abhinandanprateek <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1765: Cloudstack 9586: When using local storage wit...
Date Fri, 25 Nov 2016 07:40:52 GMT
Github user abhinandanprateek commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1765#discussion_r89574062
  
    --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625StorageProcessor.java
---
    @@ -100,36 +100,25 @@ protected SR createFileSR(final Connection conn, final String path)
{
             PBD pbd = null;
     
             try {
    -            final String srname = hypervisorResource.getHost().getUuid() + path.trim();
    -
    -            final Set<SR> srs = SR.getByNameLabel(conn, srname);
    -
    -            if (srs != null && !srs.isEmpty()) {
    -                return srs.iterator().next();
    +            final String srname = path.trim();
    --- End diff --
    
    @rhtyd, since sr is unique on a pool, adding hostname to its path does not give any advantage.
Usually MS will go thru the pool master so effectively it will end up the pool master uuid
to sr name.
    This could have avoided the race condition by probably introducing redundant SRs, but
now that the race condition is dealt with we really donot need the host uuid qualification
of SR name.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message