cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From prashanthvarma <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1580: CLOUDSTACK-9402 : Support for underlay featur...
Date Thu, 24 Nov 2016 10:33:26 GMT
Github user prashanthvarma commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1580#discussion_r89471555
  
    --- Diff: tools/marvin/marvin/lib/base.py ---
    @@ -3377,6 +3377,40 @@ def list(cls, apiclient, **kwargs):
                 cmd.listall = True
             return(apiclient.listPortableIpRanges(cmd))
     
    +
    +class NuageUnderlayPublicIpRange:
    --- End diff --
    
    Agree, but this is a key infrastructure query API for Nuage VSP SDN platform (overlay
vs underlay networking). Moreover, our custom base/utility class "nuageTestCase.py" also imports
and uses this class. Thus, we have added it to the Marvin base class "base.py" for cleaner
abstraction and code usage. 
    
    For other Nuage VSP supported feature specific/custom APIs, we tend to include them in
our custom base/utility class "nuageTestCase.py" at test/integration/plugins/nuagevsp/. 
    
    Let me know, if you still think otherwise.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message