cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rhtyd <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1580: CLOUDSTACK-9402 : Support for underlay featur...
Date Thu, 24 Nov 2016 07:48:24 GMT
Github user rhtyd commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1580#discussion_r89447356
  
    --- Diff: tools/marvin/marvin/lib/base.py ---
    @@ -3377,6 +3377,40 @@ def list(cls, apiclient, **kwargs):
                 cmd.listall = True
             return(apiclient.listPortableIpRanges(cmd))
     
    +
    +class NuageUnderlayPublicIpRange:
    --- End diff --
    
    I would avoid having non-core components/base resource classes in base.py/marvin. Instead
such a class can be moved into a utility module at test/integration/plugins/nuagevsp/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message