cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack issue #1762: CLOUDSTACK-9595 Transactions are not getting retried...
Date Wed, 23 Nov 2016 17:18:37 GMT
Github user jburwell commented on the issue:

    https://github.com/apache/cloudstack/pull/1762
  
    @serg38 corruption could happen at any point -- it's a ticking time bomb.  From a ACID
perspective, this patch fails from a consistency perspective.  All data being updated must
be re-queried and validated in order to ensure the consistency guarantee is not violated.
 In a high volume system, it's not a matter of if, but when a sequence of events will occur
and corrupt the database.   Bear in mind, these corruptions be in the content of the data
and would not yield a MySQL error.  They will be phenomenon such as phantom rows or inconsistent
data updates
    
    As I said previously, the only real solution to deadlocks is to fix the way the system
manages transactions and locks.  This patch is merely hiding an error while creating the potential
for far larger problems.
    
    For these reasons, I remain -1 on merging this patch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message