cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wido <...@git.apache.org>
Subject [GitHub] cloudstack issue #1545: CLOUDSTACK-8715: Add channel to Instances for Qemu G...
Date Wed, 23 Nov 2016 11:13:40 GMT
Github user wido commented on the issue:

    https://github.com/apache/cloudstack/pull/1545
  
    @jburwell @rhtyd I fixed most of the comments.
    
    The NPE should be fixed and the StringUtils comments as well. I didn't refactor the other
stuff @jburwell mentioned as my code is in-line with how the existing classes are written
in the same files.
    
    A new PR could do a refactor of those whole files, but it wouldn't change anything for
a end-result. The functionality is still that we have a Qemu Guest Agent inside the VMs.
    
    But this PR is open since May. Could we please merge this one in?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message