cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ProjectMoon <...@git.apache.org>
Subject [GitHub] cloudstack issue #1559: CLOUDSTACK-9280: System VM volumes can be expunged i...
Date Wed, 23 Nov 2016 09:57:49 GMT
Github user ProjectMoon commented on the issue:

    https://github.com/apache/cloudstack/pull/1559
  
    @rhtyd, in my opinion the two commits are functionally separate enough that they should
remain separate (and this might have been asked for in one of the various previous incarnations
of this PR--I don't remember). I think rolling them into one commit puts too many things in
one change. The smaller commits allows reverting of functionality easier, etc. If the change
is rebased/fast-forward merged, then it shouldn't be any different than if there were two
PRs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message