cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yvsubhash <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1761: CLOUDSTACK-9592 Empty responses from site to ...
Date Thu, 17 Nov 2016 11:16:28 GMT
Github user yvsubhash commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1761#discussion_r88432900
  
    --- Diff: core/src/com/cloud/agent/api/CheckS2SVpnConnectionsAnswer.java ---
    @@ -76,4 +76,14 @@ public String getDetail(String ip) {
             }
             return null;
         }
    +
    +    public boolean isIPPresent(String ip) {
    +        if (this.getResult()) {
    +            Boolean status = ipToConnected.get(ip);
    +            if (status != null) {
    --- End diff --
    
    @jburwell  VirtualNetworkApplianceManagerImplTest.java has all tests commented out. are
there any other place having tests covering this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message