Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: karuturi <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1572-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1572-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...
Content-Type: text/plain
Message-Id: <20161013164416.074FFDFDC4@git1-us-west.apache.org>
Date: Thu, 13 Oct 2016 16:44:16 +0000 (UTC)
archived-at: Thu, 13 Oct 2016 16:44:18 -0000

Github user karuturi commented on the issue:

    https://github.com/apache/cloudstack/pull/1572
  
    @rhtyd my point is that, even if its run on KVM, this functionality wont be covered with existing tests. I agree to your point. It was just that I had xen tests available and another run on KVM would take huge amount of effort from my side and at the end wont test the new functionality.
    
    Thanks for the email. will go through.
    
    I went through the commits on #1692. It has two bug fixes(CLOUDSTACK-9515, CLOUDSTACK-9533) and some test fixes. I dont see why its a blocker for commits to master. (probably the mail has some context. will go through)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---