cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marcaurele <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1730: VMTemplateZone needs some love
Date Tue, 25 Oct 2016 13:28:11 GMT
GitHub user marcaurele opened a pull request:

    https://github.com/apache/cloudstack/pull/1730

    VMTemplateZone needs some love

    It's incorrect to use the findIncludingRemovedBy and
    listIncludingRemovedBy for the common list and find operation. Moreover
    the DAO is trying to update the `removed` attribute to null but will
    failed (GenericDBaseDao.generateValue() will overwrite the null value
    and set a new date.
    
    Signed-off-by: Marc-Aurèle Brothier <m@brothier.org>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/exoscale/cloudstack fix/VMTemplateZoneDao

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1730.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1730
    
----
commit 3519bfb8d8aa7b90e97a57c0e79a1d520e210592
Author: Marc-Aurèle Brothier <m@brothier.org>
Date:   2016-10-25T13:18:59Z

    VMTemplateZone needs some love
    
    It's incorrect to use the findIncludingRemovedBy and
    listIncludingRemovedBy for the common list and find operation. Moreover
    the DAO is trying to update the `removed` attribute to null but will
    failed (GenericDBaseDao.generateValue() will overwrite the null value
    and set a new date.
    
    Signed-off-by: Marc-Aurèle Brothier <m@brothier.org>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message