cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rhtyd <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1729: CLOUDSTACK-9564: Fix memory leaks in VmwareCo...
Date Tue, 25 Oct 2016 11:45:10 GMT
GitHub user rhtyd opened a pull request:

    https://github.com/apache/cloudstack/pull/1729

    CLOUDSTACK-9564: Fix memory leaks in VmwareContextPool

    In a recent management server crash, it was found that the largest contributor
    to memory leak was in VmwareContextPool where a registry is held (arraylist)
    that grows indefinitely. The list itself is not used anywhere or consumed. There
    exists a hashmap (pool) that returns a list of contexts for existing poolkey
    (address/username) that is used instead.
    
    This fixes the issue by removing the arraylist registry, and limiting the
    length of the context list for a given poolkey.
    
    @blueorangutan package

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shapeblue/cloudstack vmware-memleak-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1729.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1729
    
----
commit dfabcc8a5eb0f0b78003c2f849f32e899a74ad48
Author: Rohit Yadav <rohit.yadav@shapeblue.com>
Date:   2016-10-25T09:50:33Z

    CLOUDSTACK-9564: Fix memory leaks in VmwareContextPool
    
    In a recent management server crash, it was found that the largest contributor
    to memory leak was in VmwareContextPool where a registry is held (arraylist)
    that grows indefinitely. The list itself is not used anywhere or consumed. There
    exists a hashmap (pool) that returns a list of contexts for existing poolkey
    (address/username) that is used instead.
    
    This fixes the issue by removing the arraylist registry, and limiting the
    length of the context list for a given poolkey.
    
    Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message