cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From koushik-das <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1727: CLOUDSTACK-9539: Support changing Service off...
Date Tue, 25 Oct 2016 07:10:57 GMT
Github user koushik-das commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1727#discussion_r84839712
  
    --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/vmsnapshot/DefaultVMSnapshotStrategy.java
---
    @@ -128,7 +128,7 @@ public VMSnapshot takeVMSnapshot(VMSnapshot vmSnapshot) {
                 if (options != null)
                     quiescevm = options.needQuiesceVM();
                 VMSnapshotTO target =
    -                new VMSnapshotTO(vmSnapshot.getId(), vmSnapshot.getName(), vmSnapshot.getType(),
null, vmSnapshot.getDescription(), false, current, quiescevm);
    +                new VMSnapshotTO(vmSnapshot.getId(), vmSnapshot.getName(), vmSnapshot.getType(),
null, vmSnapshot.getDescription(), false, current, quiescevm, userVm.getServiceOfferingId());
    --- End diff --
    
    Storing the service offering in DB along with vm snapshot entry should be sufficient,
don't see any reason to put it in TO object.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message