cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From syed <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1697: CLOUDSTACK-4858 Honors the snapshot.backup.ri...
Date Mon, 24 Oct 2016 15:28:32 GMT
Github user syed commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1697#discussion_r84712741
  
    --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
---
    @@ -374,8 +375,24 @@ public SnapshotInfo takeSnapshot(SnapshotInfo snapshot) {
     
                 snapshot = result.getSnashot();
                 DataStore primaryStore = snapshot.getDataStore();
    +            boolean backupFlag = Boolean.parseBoolean(configDao.getValue(Config.BackupSnapshotAfterTakingSnapshot.toString()));
    --- End diff --
    
    @nathanejohnson in #1600 I've added a flag to the create snapshot API called `locationType`
which can take `primary` or `secondary` as the parameter. We could use that here as well.
Although for this PR, a global would suffice


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message