Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: abhinandanprateek <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1678-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1678-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...
Content-Type: text/plain
Message-Id: <20160923091410.17477E01C1@git1-us-west.apache.org>
Date: Fri, 23 Sep 2016 09:14:10 +0000 (UTC)
archived-at: Fri, 23 Sep 2016 09:14:12 -0000

Github user abhinandanprateek commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1678#discussion_r80208282
  
    --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtPvlanSetupCommandWrapper.java ---
    @@ -58,11 +59,11 @@ public Answer execute(final PvlanSetupCommand command, final LibvirtComputingRes
             String result = null;
             try {
                 final String guestBridgeName = libvirtComputingResource.getGuestBridgeName();
    -            final int timeout = libvirtComputingResource.getTimeout();
    +            final Duration timeout = libvirtComputingResource.getTimeout();
     
                 if (command.getType() == PvlanSetupCommand.Type.DHCP) {
                     final String ovsPvlanDhcpHostPath = libvirtComputingResource.getOvsPvlanDhcpHostPath();
    -                final Script script = new Script(ovsPvlanDhcpHostPath, timeout, s_logger);
    +                final Script script = new Script(ovsPvlanDhcpHostPath, timeout.getMillis(), s_logger);
    --- End diff --
    
    Scripts is an external package, hope they will upgrade to Duration after Java 1.8.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---