Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: jburwell <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1678-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1678-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...
Content-Type: text/plain
Message-Id: <20160922152315.6407ADFC7E@git1-us-west.apache.org>
Date: Thu, 22 Sep 2016 15:23:15 +0000 (UTC)
archived-at: Thu, 22 Sep 2016 15:23:25 -0000

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1678#discussion_r80064254
  
    --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java ---
    @@ -3150,7 +3151,7 @@ protected long getMemoryFreeInKBs(Domain dm) throws LibvirtException {
         }
     
         private boolean canBridgeFirewall(final String prvNic) {
    -        final Script cmd = new Script(_securityGroupPath, _timeout, s_logger);
    +        final Script cmd = new Script(_securityGroupPath, _timeout.getMillis(), s_logger);
    --- End diff --
    
    Please consider adding an overridden version of the `Script(String, int, Logger)` constructor that accepts `Duration` to encapsulate this type conversion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---