Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: jburwell <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1642-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1642-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request #1642: System VMs on Managed Storage
Content-Type: text/plain
Message-Id: <20160916042023.A59FDE0252@git1-us-west.apache.org>
Date: Fri, 16 Sep 2016 04:20:23 +0000 (UTC)
archived-at: Fri, 16 Sep 2016 04:20:26 -0000

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1642#discussion_r79104400
  
    --- Diff: test/integration/plugins/solidfire/TestManagedSystemVMs.py ---
    @@ -0,0 +1,585 @@
    +# Licensed to the Apache Software Foundation (ASF) under one
    +# or more contributor license agreements.  See the NOTICE file
    +# distributed with this work for additional information
    +# regarding copyright ownership.  The ASF licenses this file
    +# to you under the Apache License, Version 2.0 (the
    +# "License"); you may not use this file except in compliance
    +# with the License.  You may obtain a copy of the License at
    +#
    +#   http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing,
    +# software distributed under the License is distributed on an
    +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +# KIND, either express or implied.  See the License for the
    +# specific language governing permissions and limitations
    +# under the License.
    +
    +import logging
    +import random
    +import SignedAPICall
    +import XenAPI
    +
    +from util import sf_util
    +
    +from marvin.cloudstackAPI import destroySystemVm
    +
    +# All tests inherit from cloudstackTestCase
    +from marvin.cloudstackTestCase import cloudstackTestCase
    +
    +from nose.plugins.attrib import attr
    +
    +# Import Integration Libraries
    +
    +# base - contains all resources as entities and defines create, delete, list operations on them
    +from marvin.lib.base import Account, Router, ServiceOffering, StoragePool, User, VirtualMachine, Zone
    +
    +# common - commonly used methods for all tests are listed here
    +from marvin.lib.common import get_domain, get_template, get_zone, list_clusters, list_hosts, list_ssvms, list_routers
    +
    +# utils - utility classes for common cleanup, external library wrappers, etc.
    +from marvin.lib.utils import cleanup_resources, wait_until
    +
    +from solidfire import solidfire_element_api as sf_api
    +
    +from time import sleep as delay
    --- End diff --
    
    `sleep` does not appear to used in this test case.  Therefore, this import can be removed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---