Return-Path: <dev-return-98791-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 71151200B80
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Wed, 14 Sep 2016 19:26:11 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 6F9EB160AB4; Wed, 14 Sep 2016 17:26:11 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id B6DC6160AB3
	for <archive-asf-public@cust-asf.ponee.io>; Wed, 14 Sep 2016 19:26:10 +0200 (CEST)
Received: (qmail 3226 invoked by uid 500); 14 Sep 2016 17:26:09 -0000
Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cloudstack.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cloudstack.apache.org>
List-Post: <mailto:dev@cloudstack.apache.org>
List-Id: <dev.cloudstack.apache.org>
Reply-To: dev@cloudstack.apache.org
Delivered-To: mailing list dev@cloudstack.apache.org
Received: (qmail 3210 invoked by uid 99); 14 Sep 2016 17:26:08 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Sep 2016 17:26:08 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id D4409E07FE; Wed, 14 Sep 2016 17:26:08 +0000 (UTC)
From: mike-tutkowski <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1642-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1642-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request #1642: System VMs on Managed Storage
Content-Type: text/plain
Message-Id: <20160914172608.D4409E07FE@git1-us-west.apache.org>
Date: Wed, 14 Sep 2016 17:26:08 +0000 (UTC)
archived-at: Wed, 14 Sep 2016 17:26:11 -0000

Github user mike-tutkowski commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1642#discussion_r78794664
  
    --- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
    @@ -1113,8 +1114,17 @@ public void cleanupStorage(boolean recurring) {
                         cleanupSecondaryStorage(recurring);
     
                         List<VolumeVO> vols = _volsDao.listVolumesToBeDestroyed(new Date(System.currentTimeMillis() - ((long) StorageCleanupDelay.value() << 10)));
    +
                         for (VolumeVO vol : vols) {
                             try {
    +                            // If this fails, just log a warning. It's ideal if we clean up the host-side clustered file
    +                            // system, but not necessary.
    +                            handleManagedStorage(vol);
    +                        } catch (Exception e) {
    --- End diff --
    
    While I'd like this code to succeed (and automatically remove the relevant SR), if something does happen, I don't want it to interfere with normal operations (a manual cleanup of the SR we failed to remove can be done).
    
    On Sep 14, 2016, at 10:08 AM, John Burwell <notifications@github.com<mailto:notifications@github.com>> wrote:
    
    
    In server/src/com/cloud/storage/StorageManagerImpl.java<https://github.com/apache/cloudstack/pull/1642#discussion_r78780699>:
    
    >                      for (VolumeVO vol : vols) {
    >                          try {
    > +                            // If this fails, just log a warning. It's ideal if we clean up the host-side clustered file
    > +                            // system, but not necessary.
    > +                            handleManagedStorage(vol);
    > +                        } catch (Exception e) {
    
    
    Why are all checked and unchecked exceptions being caught here?
    
    -
    You are receiving this because you were mentioned.
    Reply to this email directly, view it on GitHub<https://github.com/apache/cloudstack/pull/1642/files/d3bdd6196e3005efdd29b318c84888d8098999ee#r78780699>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AC4SHyOdz_KUrC-CM97Ii_Vj-RiX0mOBks5qqBwGgaJpZM4Jlzqr>.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---