Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 279D8200B81 for ; Tue, 13 Sep 2016 23:23:59 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 26382160AD2; Tue, 13 Sep 2016 21:23:59 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 70C7A160AAA for ; Tue, 13 Sep 2016 23:23:58 +0200 (CEST) Received: (qmail 18233 invoked by uid 500); 13 Sep 2016 21:23:57 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 18222 invoked by uid 99); 13 Sep 2016 21:23:57 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Sep 2016 21:23:57 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 1AB0CE00D6; Tue, 13 Sep 2016 21:23:57 +0000 (UTC) From: jburwell To: dev@cloudstack.apache.org Reply-To: dev@cloudstack.apache.org References: In-Reply-To: Subject: [GitHub] cloudstack pull request #1511: 4.9/master bountycastle changes Content-Type: text/plain Message-Id: <20160913212357.1AB0CE00D6@git1-us-west.apache.org> Date: Tue, 13 Sep 2016 21:23:57 +0000 (UTC) archived-at: Tue, 13 Sep 2016 21:23:59 -0000 Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1511#discussion_r78647190 --- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java --- @@ -571,43 +573,44 @@ public void runUploadSslCertNotX509() throws IOException, IllegalAccessException public void runUploadSslCertBadFormat() throws IOException, IllegalAccessException, NoSuchFieldException { // Reading appropritate files - String certFile = URLDecoder.decode(getClass().getResource("/certs/bad_format_cert.crt").getFile(),Charset.defaultCharset().name()); - String keyFile = URLDecoder.decode(getClass().getResource("/certs/rsa_self_signed.key").getFile(),Charset.defaultCharset().name()); + final String certFile = URLDecoder.decode(getClass().getResource("/certs/bad_format_cert.crt").getFile(),Charset.defaultCharset().name()); + final String keyFile = URLDecoder.decode(getClass().getResource("/certs/rsa_self_signed.key").getFile(),Charset.defaultCharset().name()); - String cert = readFileToString(new File(certFile)); - String key = readFileToString(new File(keyFile)); + final String cert = readFileToString(new File(certFile)); + final String key = readFileToString(new File(keyFile)); --- End diff -- Please see line comments 158-159 as they apply to lines 579-580 as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---