Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: jburwell <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1578-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1578-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request #1578: CLOUDSTACK-9401 : Support for Internal DNS in...
Content-Type: text/plain
Message-Id: <20160907032828.B78BBDFCC0@git1-us-west.apache.org>
Date: Wed,  7 Sep 2016 03:28:28 +0000 (UTC)
archived-at: Wed, 07 Sep 2016 03:28:30 -0000

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1578#discussion_r77755409
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java ---
    @@ -386,6 +392,17 @@ private Answer executeRequest(TrashNetworkVspCommand cmd) {
             }
         }
     
    +    private Answer executeRequest(UpdateDhcpOptionVspCommand cmd) {
    +        try {
    +            isNuageVspManagerLoaded();
    +            _nuageVspGuruClient.applyDhcpOptions(cmd.getDhcpOptions(), cmd.getNetwork());
    +            return new Answer(cmd, true, "Update DhcpOptions on VM's in network: " + cmd.getNetwork().getName() + " on Nuage VSD " + _hostName);
    +        } catch (ExecutionException | ConfigurationException e) {
    +            s_logger.error("Failure during " + cmd + " on Nuage VSD " + _hostName, e);
    --- End diff --
    
    Please add ``cmd.getDhcpOptions`` to the log message to assist with operational debugging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---