Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: jburwell <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1578-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1578-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request #1578: CLOUDSTACK-9401 : Support for Internal DNS in...
Content-Type: text/plain
Message-Id: <20160907031158.228FAE04D9@git1-us-west.apache.org>
Date: Wed,  7 Sep 2016 03:11:58 +0000 (UTC)
archived-at: Wed, 07 Sep 2016 03:12:00 -0000

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1578#discussion_r77754362
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ImplementNetworkVspCommand.java ---
    @@ -56,7 +56,7 @@ public boolean equals(Object o) {
     
             ImplementNetworkVspCommand that = (ImplementNetworkVspCommand) o;
     
    -        if (_dnsServers != null ? !_dnsServers.equals(that._dnsServers) : that._dnsServers != null) return false;
    +        if (_dhcpOption != null ? !_dhcpOption.equals(that._dhcpOption) : that._dhcpOption != null) return false;
    --- End diff --
    
    Please consider simplifying this ``if`` block with Guava's ``Objects.equals``.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---