cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rhtyd <>
Subject [GitHub] cloudstack pull request #1694: CLOUDSTACK-9509: Host Connects Without Storag...
Date Wed, 28 Sep 2016 07:02:31 GMT
Github user rhtyd commented on a diff in the pull request:
    --- Diff: server/test/com/cloud/storage/listener/ ---
    @@ -0,0 +1,80 @@
    +// Licensed to the Apache Software Foundation (ASF) under one
    +// or more contributor license agreements.  See the NOTICE file
    +// distributed with this work for additional information
    +// regarding copyright ownership.  The ASF licenses this file
    +// to you under the Apache License, Version 2.0 (the
    +// "License"); you may not use this file except in compliance
    +// with the License.  You may obtain a copy of the License at
    +// Unless required by applicable law or agreed to in writing,
    +// software distributed under the License is distributed on an
    +// KIND, either express or implied.  See the License for the
    +// specific language governing permissions and limitations
    +// under the License.
    +import org.junit.Before;
    +import org.junit.Test;
    +import org.mockito.Mockito;
    +import java.util.Collections;
    +public class StoragePoolMonitorTest {
    +    private StorageManagerImpl storageManager;
    +    private PrimaryDataStoreDao poolDao;
    +    private StoragePoolMonitor storagePoolMonitor;
    +    private HostVO host;
    +    private StoragePoolVO pool;
    +    private StartupRoutingCommand cmd;
    +    @Before
    +    public void setUp() throws Exception {
    +        storageManager = Mockito.mock(StorageManagerImpl.class);
    +        poolDao = Mockito.mock(PrimaryDataStoreDao.class);
    +        storagePoolMonitor = new StoragePoolMonitor(storageManager, poolDao);
    +        host = new HostVO("some-uuid");
    --- End diff --
    This a unit test, uniqueness of the VO object is not necessary. We just want to create
a hostVO object for testing that could have any uuid.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message