cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1694: CLOUDSTACK-9509: Host Connects Without Storag...
Date Tue, 27 Sep 2016 15:08:13 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1694#discussion_r80714972
  
    --- Diff: server/src/com/cloud/storage/listener/StoragePoolMonitor.java ---
    @@ -99,12 +99,12 @@ public void processConnect(Host host, StartupCommand cmd, boolean
forRebalance)
                         }
     
                         Long hostId = host.getId();
    -                    s_logger.debug("Host " + hostId + " connected, sending down storage
pool information ...");
    +                    s_logger.debug("Host " + hostId + " connected, connecting host to
shared pool id " + pool.getId() + " and sending storage pool information ...");
    --- End diff --
    
    Please wrap in a `if (s_logger.isDebugEnabled)` to check to avoid unnecessary string concatenation
when the `DEBUG` level is disabled.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message