cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...
Date Mon, 26 Sep 2016 03:31:35 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1678#discussion_r80404113
  
    --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtPvlanSetupCommandWrapper.java
---
    @@ -87,7 +88,7 @@ public Answer execute(final PvlanSetupCommand command, final LibvirtComputingRes
                 } else if (command.getType() == PvlanSetupCommand.Type.VM) {
                     final String ovsPvlanVmPath = libvirtComputingResource.getOvsPvlanVmPath();
     
    -                final Script script = new Script(ovsPvlanVmPath, timeout, s_logger);
    +                final Script script = new Script(ovsPvlanVmPath, timeout.getMillis(),
s_logger);
    --- End diff --
    
    @abhinandanprateek the `Script` class is in the `com.cloud.utils.script` which is part
of the project.  What prevents us from adding a constructor that class?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message