cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From milamberspace <...@git.apache.org>
Subject [GitHub] cloudstack issue #1669: Make CloudStack JSP-free
Date Sun, 25 Sep 2016 10:56:03 GMT
Github user milamberspace commented on the issue:

    https://github.com/apache/cloudstack/pull/1669
  
    
    Not look good to me, I've found these issues:
    
    The quote ' in French UI (and other language using quote) is precede by a backslash:
    ![selection_342](https://cloud.githubusercontent.com/assets/3995882/18814768/ff6e26be-8314-11e6-8325-51b0146d53ee.png)
    
    ![selection_341](https://cloud.githubusercontent.com/assets/3995882/18814770/08b094f0-8315-11e6-98e3-34726b8984a3.png)
    
    In Korean (and other language not fully translated), the default language (EN) is not
use to display the missing translations:
    ![selection_343](https://cloud.githubusercontent.com/assets/3995882/18814785/3c012eb4-8315-11e6-9db5-237378f3c552.png)
    
    ![selection_344](https://cloud.githubusercontent.com/assets/3995882/18814787/416b4650-8315-11e6-8c22-fc6da1f89cc3.png)
    
    Also, the generated files under the directory client/ui/l10n/ (*.js) must have the Apache
license header.
    (and probably add the l10n directory into the project's gitignore )
    
    I don't like the idea that we have two L10N files for each language (the message_xx.properties
and the (generated) xx.js. I thinks we should study to change the current process from/in
transifex (move to JSON key/value file instead of the current message.properties)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message