cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...
Date Thu, 22 Sep 2016 15:23:15 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1678#discussion_r80063605
  
    --- Diff: plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
---
    @@ -636,7 +637,7 @@ public ExecutionResult executeInVR(final String routerIP, final String
script, f
     
             try {
                 result = SshHelper.sshExecute(routerIP, DEFAULT_DOMR_SSHPORT, "root", getSystemVMKeyFile(),
null, "/opt/cloud/bin/" + script + " " + args,
    -                    60000, 60000, timeout * 1000);
    +                    60000, 60000, (int)timeout.getMillis());
    --- End diff --
    
    Please consider defining an override of the ``SshHelper.sshExecute`` method that accepts
a ``Duration`` in order to encapsulate this conversion.  We should also consider deprecating
the version that accepts ``int``.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message