cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1678: CLOUDSTACK-9503: Increased the VR script time...
Date Thu, 22 Sep 2016 15:23:15 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1678#discussion_r80062899
  
    --- Diff: core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java
---
    @@ -374,9 +375,9 @@ private Answer execute(AggregationControlCommand cmd) {
                     FileConfigItem fileConfigItem = new FileConfigItem(VRScripts.CONFIG_CACHE_LOCATION,
cfgFileName, sb.toString());
                     ScriptConfigItem scriptConfigItem = new ScriptConfigItem(VRScripts.VR_CFG,
"-c " + VRScripts.CONFIG_CACHE_LOCATION + cfgFileName);
                     // 120s is the minimal timeout
    -                int timeout = answerCounts * _eachTimeout;
    -                if (timeout < 120) {
    -                    timeout = 120;
    +                Duration timeout = Duration.standardSeconds(answerCounts * _eachTimeout.getStandardSeconds());
    +                if (timeout.getStandardSeconds() < 120L) {
    +                    timeout = Duration.standardSeconds(120L);
    --- End diff --
    
    Consider using the previously defined constant here for ensured consistency between he
check and the value used.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message