cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1578: CLOUDSTACK-9401 : Support for Internal DNS in...
Date Wed, 07 Sep 2016 03:38:40 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1578#discussion_r77755943
  
    --- Diff: test/integration/plugins/nuagevsp/nuageTestCase.py ---
    @@ -77,85 +117,104 @@ def setUpClass(cls, zone=None):
             cls.test_data["virtual_machine"]["zoneid"] = cls.zone.id
             cls.test_data["virtual_machine"]["template"] = cls.template.id
     
    -        # Create service offering
    -        cls.service_offering = ServiceOffering.create(cls.api_client,
    -                                                      cls.test_data["service_offering"]
    -                                                      )
    -        cls._cleanup = [cls.service_offering]
    -
             # Check if the host hypervisor type is simulator
    -        cls.isSimulator = Hypervisor.list(cls.api_client, zoneid=cls.zone.id)[0].name
== "Simulator"
    +        cls.isSimulator = Hypervisor.list(
    +            cls.api_client,
    +            zoneid=cls.zone.id)[0].name == "Simulator"
     
             # Get configured Nuage VSP device details
             try:
    -            physical_networks = PhysicalNetwork.list(cls.api_client, zoneid=cls.zone.id)
    +            physical_networks = PhysicalNetwork.list(
    +                cls.api_client,
    +                zoneid=cls.zone.id
    +            )
                 for pn in physical_networks:
                     if pn.isolationmethods == "VSP":
                         cls.vsp_physical_network = pn
                         break
    -            cls.nuage_vsp_device = Nuage.list(cls.api_client,
    -                                              physicalnetworkid=cls.vsp_physical_network.id
    -                                              )[0]
    +            cls.nuage_vsp_device = Nuage.list(
    +                cls.api_client,
    +                physicalnetworkid=cls.vsp_physical_network.id)[0]
                 pns = cls.config.zones[0].physical_networks
    -            providers = filter(lambda physical_network: "VSP" in physical_network.isolationmethods,
pns)[0].providers
    -            devices = filter(lambda provider: provider.name == "NuageVsp", providers)[0].devices
    +            providers = filter(lambda physical_network:
    +                               "VSP" in physical_network.isolationmethods,
    +                               pns)[0].providers
    +            devices = filter(lambda provider:
    +                             provider.name == "NuageVsp",
    +                             providers)[0].devices
                 cls.nuage_vsp_device.username = devices[0].username
                 cls.nuage_vsp_device.password = devices[0].password
                 cls.cms_id = cls.nuage_vsp_device.cmsid
             except Exception as e:
                 cls.tearDownClass()
    -            raise unittest.SkipTest("Warning: Could not get configured Nuage VSP device
details - %s" % e)
    +            raise unittest.SkipTest("Warning: Could not get configured "
    +                                    "Nuage VSP device details - %s" % e)
    --- End diff --
    
    Why shouldn't this exception cause the test to fail?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message